chore(build): drop minification from index bundler#1215
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 17, 2026
Merged
chore(build): drop minification from index bundler#1215John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
Removes the partial-minify branch (minifyWhitespace/minifyIdentifiers) in createIndexConfig so the index loader is produced unminified, matching the rest of the prod build config. Also drops the now-redundant `minify: false` from the package-builder templates that called it. Rationale: simpler, one shape of output, easier for contributors to read.
Bill Li (billxinli)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createIndexConfigso the index loader output is straight, unminified JavaScript — matching the rest of the prod build.minify: falsetocreateIndexConfigso the "off" state is one obvious thing.minify: falsearg from the two package-builder template callers (the util enforces it).Why
One shape of output is easier to read, easier to grep when debugging, and eliminates a two-branched
minifypath that contributors had to reason about. We don't ship minified bundles anywhere, so there's no benefit to the partial version.Test plan
pnpm run typepassespnpm run build:clisucceeds and produces unminified outputNote
Low Risk
Build output formatting change only (minification toggling removed) with no runtime logic or security-sensitive behavior changes; main risk is unexpected bundle size/perf differences.
Overview
The index-loader esbuild config (
createIndexConfig) no longer accepts aminifyoption and now always emits unminified output via an explicitminify: false, removing the previous partial-minification branch.The package-builder templates for
cli-packageandcli-sentry-packageare updated to stop passingminify: false, relying on the utility’s enforced behavior.Reviewed by Cursor Bugbot for commit 32710d6. Configure here.